This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
Update packaging, upgrade to TypeScript 1.8 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kitsonk
commented
Feb 24, 2016
kitsonk
commented
- Migrate to npm only for dependencies
- Add typings to package.json for distribution builds
- Remove the _modules path
- Update form.ts to be compatible with TS 1.8
- Update other npm dependencies to latest versions
- Amend tslint.json to be compatible latest version
- Migrate to npm only for dependencies - Add typings to package.json for distribution builds - Remove the _modules path - Update form.ts to be compatible with TS 1.8 - Update other npm dependencies to latest versions - Amend tslint.json to be compatible latest version
| ///<reference path="../_modules/dojo-core/typings/dojo-core/dojo-core-2.0.0-pre.d.ts"/> | ||
| ///<reference path="../node_modules/dojo-core/typings/dojo-core/dojo-core-2.0.0-alpha.2.d.ts"/> | ||
| /// <reference path="../node_modules/dojo-loader/typings/dojo-loader/dojo-loader-2.0.0-alpha.4.d.ts" /> | ||
| /// <reference path="../tests/typings/node/node.d.ts" /> |
|
Looks good 👍 |
| @@ -1 +1,3 @@ | |||
| ///<reference path="../_modules/dojo-core/typings/dojo-core/dojo-core-2.0.0-pre.d.ts"/> | |||
| ///<reference path="../node_modules/dojo-core/typings/dojo-core/dojo-core-2.0.0-alpha.2.d.ts"/> | |||
Current coverage is
|
|
@vansimke have you reviewed this? If so, if you could add a comment to that effect. |
|
Sorry, haven't looked at it yet. Didn't realize this was a PR, so I didn't look for it. I'll take a look this morning. |
|
This looks good to me |
| }, | ||
| "devDependencies": { | ||
| "codecov.io": "0.1.6", | ||
| "dojo-loader": "2.0.0-alpha.1", | ||
| "dojo-loader": ">2.0.0-alpha", |
There was a problem hiding this comment.
this is still valid semver for beta.2
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.